[PATCH] D98465: Clean up unnecessary dependency
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 12 14:51:39 PST 2021
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
In D98465#2623030 <https://reviews.llvm.org/D98465#2623030>, @dangyi wrote:
> Thank you for your detailed explanation. I thought `LINK_COMPONENTS` merely means, well, link dependency. I'll update the patch.
If somehow an inline function in a DebugInfo/CodeView header is moved to the associated .cpp file, a virtual function with non-vague-linkage vtable is needed, etc, the developer may have to add back the dependency.
If you don't have commit access, please provide your name and email https://llvm.org/docs/Phabricator.html#committing-someone-s-change-from-phabricator
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98465/new/
https://reviews.llvm.org/D98465
More information about the llvm-commits
mailing list