[PATCH] D98557: [MemorySSA] Don't bail on phi starting access

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Analysis/MemorySSA.cpp:2405
     unsigned &UpwardWalkLimit) {
-  if (isa<MemoryPhi>(StartingAccess))
-    return StartingAccess;
+  assert(!isa<MemoryUse>(StartingAccess) && "Use cannot be defining access");
 
----------------
The code previously fetched the defining access for MemoryUses, but imho this doesn't make sense for this API, which accepts a defining access as the starting point, unlike the other one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98557/new/

https://reviews.llvm.org/D98557