[PATCH] D96827: [DWARF] Check for AddrOffsetSectionBase to work with DWO Units.

Fri Mar 12 13:53:52 PST 2021

dblaikie added a comment.

In D96827#2623409 <https://reviews.llvm.org/D96827#2623409>, @ayermolo wrote:

> In D96827#2623393 <https://reviews.llvm.org/D96827#2623393>, @dblaikie wrote:
>
>> Looks good - just a couple of minor fixes to make before committing.
>>
>> (I assume by your patch that this is only reproducible with a linked binary? please confirm that (in a comment here) before committing)
>
> Sorry for not replying. I was trying to see if I could fix the build failure. It works on my CentOS machine.
> Yes I think it's only reproducible with the binary/object combo. You need to have .debug_addr to be in different file than DWO CU. The case where they are all in same file is covered by LLC, Case 1, and works.

Oh, you could still have two separate files, though, without it being a linked binary? IF you took the assembly from LLVM for split DWARF (which does have all the assembly for both .o and .dwo in one assembly file) and then manually split that into two .s files and assembled each - could you then reproduce the problem? If you can do it that way, please change the test to contain the two .s files (or one .s file with conditional directives so the .o/.dwo can be compiled to different files)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96827/new/

https://reviews.llvm.org/D96827