[PATCH] D98511: [llvm-objcopy][NFC] Move ownership keeping code into the restoreStatOnFile().

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 12 13:38:58 PST 2021


dblaikie added a comment.

In D98511#2623027 <https://reviews.llvm.org/D98511#2623027>, @avl wrote:

>> I'm not sure if this would be a big issue but restoreStatOnFile also runs on the split dwo file, and will keep its ownership with this change. I don't think GNU assembler does that currently.
>
> I though it would be good to keep ownership for all modes. If it is important to not doing it for split dwo file case then I will add corresponding check.

I'm fine with the new behavior, if I'm understanding correctly and it means that dwo files will be treated more like/the same as how .o files have been treated by both GCC and Clang for some time now. (GCC's behavior is probably an artifact of running llvm-objcopy to make the dwo file)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98511/new/

https://reviews.llvm.org/D98511



More information about the llvm-commits mailing list