[PATCH] D98469: [NVPTX] Avoid temp copy of byval kernel parameters.

[Justin Lebar via Phabricator via llvm-commits]

jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.

...in which we all remember why we like writing this recursively.  :D

🚢



================
Comment at: llvm/lib/Target/NVPTX/NVPTXLowerArgs.cpp:161
+// Only Load and GEP are supported.
+static void ConvertToParamAS(Value *OldUser, Value *Param) {
+  Instruction *I = dyn_cast<Instruction>(OldUser);
----------------
I think there was a clang-tidy warning at one point saying this should be lower-case c?


================
Comment at: llvm/lib/Target/NVPTX/NVPTXLowerArgs.cpp:183
+      GEPsToDelete.push_back(GEP);
+      continue;
+    } else
----------------
needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98469/new/

https://reviews.llvm.org/D98469