[PATCH] D98422: [Alias] Add a ah-hoc pattern for aliasGEP

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 12 13:19:59 PST 2021


reames added a comment.

If I'm reading the code right, this looks potentially expensive for compile time.  You're recursing on each phi operand individually.  Can we narrow the scope any without loosing your motivating example?

I agree that this seems to make more sense in isKnownNonEqual than basic aa.  In that context, it would naturally follow to handle two phis with N-1 trivially different values (e.g. constants), and recurse through at most one input pair.  Would that handle your example?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98422/new/

https://reviews.llvm.org/D98422



More information about the llvm-commits mailing list