[PATCH] D98545: [lld-macho][nfc] Give every SyntheticSection a fake InputSection

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo added inline comments.


================
Comment at: lld/MachO/SymbolTable.cpp:164
+                                   bool isLinkerInternal) {
+  auto s = addDefined(name, nullptr, isec, value, /*isWeakDef=*/false,
+                      isPrivateExtern);
----------------
clang-tidy: warning: 'auto s' can be declared as 'auto *s' [llvm-qualified-auto]



================
Comment at: lld/MachO/SyntheticSections.cpp:770-771
     if (auto *defined = dyn_cast<Defined>(sym)) {
+      if (defined->linkerInternal)
+        continue;
       assert(defined->isExternal());
----------------
This is true for dso_handle, but probably not for the mh_* symbols?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98545/new/

https://reviews.llvm.org/D98545