[PATCH] D98511: [llvm-objcopy][NFC] Move ownership keeping code into the restoreStatOnFile().

[Alexey Lapshin via Phabricator via llvm-commits]

avl added a comment.

> I'm not sure if this would be a big issue but restoreStatOnFile also runs on the split dwo file, and will keep its ownership with this change. I don't think GNU assembler does that currently.

I though it would be good to keep ownership for all modes. If it is important to not doing it for split dwo file case then I will add corresponding check.

> Also you could delete the code added in https://reviews.llvm.org/D98511 for passing user and group ID since they are no longer needed, assuming the new behavior is what we want.

I suppose this code:

  explicit FileBuffer(StringRef FileName, bool Keep, unsigned UID, unsigned GID)
       : Buffer(FileName), KeepOwnership(Keep), UserID(UID), GroupID(GID) {}

Ok, will delete it. thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98511/new/

https://reviews.llvm.org/D98511