[PATCH] D97954: [RISCV] Support fixed-length vectors in the calling convention

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 12 10:36:21 PST 2021


craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM other than 1 nit.



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:5138
     MVT ArgVT = ArgIdx.value().VT;
-    if (ArgVT.isScalableVector() &&
-        ArgVT.getVectorElementType().SimpleTy == MVT::i1)
+    if (ArgVT.isVector() && ArgVT.getVectorElementType().SimpleTy == MVT::i1)
       return ArgIdx.index();
----------------
i know it was there before, but the ".SimpleTy" here is redundant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97954/new/

https://reviews.llvm.org/D97954



More information about the llvm-commits mailing list