[PATCH] D98276: [AsmParser][SystemZ][z/OS] Introducing HLASM Parser support to AsmParser - Part 1

[Anirudh Prasad via Phabricator via llvm-commits]

anirudhp marked 2 inline comments as done and an inline comment as not done.
anirudhp added inline comments.


================
Comment at: llvm/include/llvm/MC/MCAsmInfo.h:566
 
+  bool getEmitGNUAsmStartIndentationMarker() const {
+    return EmitGNUAsmStartIndentationMarker;
----------------
abhina.sreeskantharajan wrote:
> nit: Move this between getCommentString and getLabelSuffix to maintain the same order the class members are listed as.
Sure. But I'll wait until https://reviews.llvm.org/D97703 is merged in, as its around the same area. When I rebase it, I'll make sure to move it to the right place.


================
Comment at: llvm/lib/MC/MCParser/AsmParser.cpp:6139
+
+  checkAndGenerateLOCDirectiveForInstruction(ParseHadError, Loc);
+
----------------
uweigand wrote:
> I guess now this doesn't really have to be a separate routine any more?
Yes, you're right. But since the rest of the function is essentially just `getTargetParser().ParseInstruction` and `getTargetParser().MatchAndEmitInstruction()`, I didn't want to decompose logic in `checkAndGenerateLOCDirectiveForInstruction` into the same function. I'd rather have it as a separate routine, since it does something different.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98276/new/

https://reviews.llvm.org/D98276