[PATCH] D98486: [TableGen/GlobalISel] Emit MI_predicate custom code for PatFrags (not only PatFrag)

Petar Avramovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 12 05:54:07 PST 2021


Petar.Avramovic added a comment.

Looks good, I would like for other reviewers to also take a look.



================
Comment at: llvm/test/TableGen/GlobalISelEmitterCustomPredicate.td:183
+
+def patfrags_test_pat : PatFrags<
+  (ops node:$x, node:$y, node:$z),
----------------
You said that matcher code was emitted also for PatFrags. GlobalISel emmiter ignores this for me without the patch (does not report skip message either). Am I missing something/is that another test? Was the emitted match code broken?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98486/new/

https://reviews.llvm.org/D98486



More information about the llvm-commits mailing list