[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

[Abhina Sree via Phabricator via llvm-commits]

abhina.sreeskantharajan added a comment.

I like the idea of falling back to python's strerror if the LLVM_LIT_ERRC_MESSAGES is not defined.

> Where should the function be called and how should it be supplied to lit? I currently do so in config-ix.cmake but this eg. does not get installed with LLVM and I feel like is almost definitely wrong.
> Should it be maybe be called and passed by each project to the configure_lit_site_cfg?

I'm not an expert on this part, but glancing at how the other modules are used in this folder llvm/cmake/modules/ it seems that they are included in the CMakeList.txts instead of config-ix.cmake. 
For example, UseLibTool.cmake is included in llvm/CMakeLists.txt. HandleLLVMOptions.cmake is included in many CMakeLists.txt including clang/CMakeLists.txt, lld/CMakeLists.txt, llvm/CMakeLists.txt. For this patch, I think we only need it for clang, lld and llvm at the moment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98278/new/

https://reviews.llvm.org/D98278