[PATCH] D98323: [lld-macho] implement options -map

[Roy via Phabricator via llvm-commits]

woshiccm added a comment.



In D98323#2619689 <https://reviews.llvm.org/D98323#2619689>, @thakis wrote:

> New code should be covered by a test added in the same change. See https://llvm.org/docs/TestingGuide.html#writing-new-regression-tests and https://llvm.org/docs/CommandGuide/FileCheck.html#tutorial -- and look at the existing tests in lld/test/MachO for many examples, of course :)

I added map-file.s for test



================
Comment at: lld/MachO/MapFile.cpp:73-74
+// Construct a map from symbols to their stringified representations.
+// Demangling symbols (which is what toString() does) is slow, so
+// we do that in batch using parallel-for.
+static DenseMap<macho::Symbol *, std::string>
----------------
int3 wrote:
> this function isn't using parallel-for :) leave a TODO?
done


================
Comment at: lld/MachO/MapFile.cpp:84
+
+static llvm::StringRef getArchName(Architecture Arch) {
+  switch (Arch) {
----------------
int3 wrote:
> llvm/TextAPI/MachO/Architecture.h defines `getArchitectureName()`
done


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98323/new/

https://reviews.llvm.org/D98323