[PATCH] D93927: [ArgPromotion] Copy !range metadata for loads.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 12 02:18:07 PST 2021


fhahn added inline comments.


================
Comment at: llvm/test/Transforms/ArgumentPromotion/metadata.ll:7
+; CHECK-SAME: (i32* [[X:%.*]]) {
+; CHECK-NEXT:    [[X_VAL:%.*]] = load i32, i32* [[X]], align 4, !range !0
+; CHECK-NEXT:    [[TMP1:%.*]] = call i32 @f_load_range(i32 [[X_VAL]])
----------------
can you add a manual check line at the end of the file to check that the `!0` metadata matches the expected range?


================
Comment at: llvm/test/Transforms/ArgumentPromotion/metadata.ll:32
+  %1 = call i32* @f_load_nonnull(i32** %x)
+  ret i32* %1
+}
----------------
please also add a test for dereferenceable


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93927/new/

https://reviews.llvm.org/D93927



More information about the llvm-commits mailing list