[PATCH] D97122: [SCEV] Improve handling of pointer compares involving subtractions (WIP).

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 12 01:24:26 PST 2021


mkazantsev added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:10991
+      bool CheckX = Pred == CmpInst::ICMP_ULE ? isKnownNonPositive(X)
+                                              : isKnownPositive(X);
+      return Y == RHS && CheckX && isKnownNonNegative(Y) &&
----------------
For `ule` case the comment says that `X` is non-negative and the code checks it's non-positive. I guess it's a bug in code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97122/new/

https://reviews.llvm.org/D97122



More information about the llvm-commits mailing list