[PATCH] D98399: [RISCV] Fix up stale VECREDUCE comments. NFC.

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 12 00:56:30 PST 2021


This revision was automatically updated to reflect the committed changes.
Closed by commit rG4d2d5855c729: [RISCV] Fix up stale VECREDUCE comments. NFC. (authored by frasercrmck).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98399/new/

https://reviews.llvm.org/D98399

Files:
  llvm/lib/Target/RISCV/RISCVISelLowering.cpp


Index: llvm/lib/Target/RISCV/RISCVISelLowering.cpp
===================================================================
--- llvm/lib/Target/RISCV/RISCVISelLowering.cpp
+++ llvm/lib/Target/RISCV/RISCVISelLowering.cpp
@@ -2557,9 +2557,6 @@
   }
 }
 
-// Take a (supported) standard ISD reduction opcode and transform it to a RISCV
-// reduction opcode. Note that this returns a vector type, which must be
-// further processed to access the scalar result in element 0.
 SDValue RISCVTargetLowering::lowerVECREDUCE(SDValue Op,
                                             SelectionDAG &DAG) const {
   SDLoc DL(Op);
@@ -3634,9 +3631,6 @@
   case ISD::VECREDUCE_UMAX:
   case ISD::VECREDUCE_SMIN:
   case ISD::VECREDUCE_UMIN:
-    // The custom-lowering for these nodes returns a vector whose first element
-    // is the result of the reduction. Extract its first element and let the
-    // legalization for EXTRACT_VECTOR_ELT do the rest of the job.
     if (SDValue V = lowerVECREDUCE(SDValue(N, 0), DAG))
       Results.push_back(V);
     break;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98399.330174.patch
Type: text/x-patch
Size: 1046 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210312/90617ab1/attachment.bin>


More information about the llvm-commits mailing list