[PATCH] D98276: [AsmParser][SystemZ][z/OS] Introducing HLASM Parser support to AsmParser - Part 1

[Ulrich Weigand via Phabricator via llvm-commits]

uweigand added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp:511
+    EmitGCCInlineAsmStr(AsmStr, MI, MMI, AsmPrinterVariant,
+                        EmitGNUAsmStartIndentationMarker, AP, LocCookie, OS);
+  } else
----------------
Maybe just pass MAI into the routine, so it can check those parameters itself?


================
Comment at: llvm/lib/MC/MCParser/AsmParser.cpp:6139
+
+  checkAndGenerateLOCDirectiveForInstruction(ParseHadError, Loc);
+
----------------
I guess now this doesn't really have to be a separate routine any more?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98276/new/

https://reviews.llvm.org/D98276