[PATCH] D96628: [VPlan] Add plain text (not DOT's digraph) dumps

Andrei Elovikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 11 12:36:18 PST 2021


a.elovikov added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/icmp-uniforms.ll:40
+; CHECK-NEXT: loop:
+; CHECK-NEXT:   WIDEN-INDUCTION %iv = phi %bc.resume.val, %iv.next
+; CHECK-NEXT:   WIDEN ir<%cond0> = icmp ir<%iv>, ir<13>
----------------
a.elovikov wrote:
> fhahn wrote:
> > Did the value here change because the plan gets printed later?
> I didn't study in details, but I'd expect it to be so. Is that something expected for you, or do you want me to study that change in details (my knowledge of the VPlan pipeline is still limited)?
Yes, it gets changed in the middle of InnerLoopVectorizer::createVectorizedLoopSkeleton/InnerLoopVectorizer::createInductionResumeValues. 

We seem to be using original LLVM IR value through `VPlanIngredient` when printing `VPWidenIntOrFpInductionRecipe`, so modifying original loop when creating the skeleton changes printing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96628/new/

https://reviews.llvm.org/D96628



More information about the llvm-commits mailing list