[PATCH] D97994: [lld/mac] ad-hoc sign dylibs and bundles on arm64 by default, support -(no_)adhoc_codesign flags

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 11 11:26:10 PST 2021


smeenai added inline comments.


================
Comment at: lld/MachO/Driver.cpp:848
 
+  config->adhocCodesign =
+      args.hasFlag(OPT_adhoc_codesign, OPT_no_adhoc_codesign,
----------------
smeenai wrote:
> Should we be setting this for all arm64 binaries, or only arm64 binaries targeting macOS?
ld64 appears to only ad-hoc sign macOS binaries.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97994/new/

https://reviews.llvm.org/D97994



More information about the llvm-commits mailing list