[PATCH] D98187: [SamplePGO] Skip inlinee profile scaling for sample loader inlining

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 11 10:18:06 PST 2021


wenlei added a comment.

In D98187#2619936 <https://reviews.llvm.org/D98187#2619936>, @wmi wrote:

> In D98187#2618612 <https://reviews.llvm.org/D98187#2618612>, @wmi wrote:
>
>> In D98187#2618605 <https://reviews.llvm.org/D98187#2618605>, @wenlei wrote:
>>
>>> @wmi any concern with landing this change? I don't expect any issues, but just to be prudent do you want to experiment before this is landed?
>>
>> That is a nice catch! I will definitely experiment it and expect some improvement from it. Will have the data tomorrow and get back.
>
> I got ~0.2% improvement on our search benchmark. That is a nice improvement. Thanks!

Thanks for the measurement, great to know it helps.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98187/new/

https://reviews.llvm.org/D98187



More information about the llvm-commits mailing list