[PATCH] D86377: [tsan] Use large address space mapping on Apple Silicon Macs

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek added inline comments.


================
Comment at: compiler-rt/lib/tsan/rtl/tsan_platform_posix.cpp:102
 
-#if defined(__aarch64__) && defined(__APPLE__)
+#if defined(__aarch64__) && !HAS_48_BIT_ADDRESS_SPACE
   ProtectRange(HeapMemEnd(), ShadowBeg());
----------------
MaskRay wrote:
> This change is not correct for aarch64-*-linux.
> 
> I've fixed it in 32b684acc4490fbddce39d501e577cb029728e41
Thank you for fixing this!

Since I cannot find the mentioned hash anywhere, here's the fix for anyone else's reference: <https://github.com/llvm/llvm-project/commit/5af991d46497c9473d2a0fd0989aa4ff4e6a0643>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86377/new/

https://reviews.llvm.org/D86377