[PATCH] D96883: Add support for JSON output style to llvm-symbolizer

Alex Orlov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 11 09:20:33 PST 2021


aorlov updated this revision to Diff 329985.
aorlov added a comment.

Error handling is not consistent through the llvm-symbolizer and the library and needs some love and care. I’d like to keep it out of the scope of this patch, though. It will be a separate patch to refactor the error handling. In context of this patch the proposed error reporting follows the pattern of how it is currently done and does not make it worth, and in this sense serves the purpose. I’ll propose a separate patch for the rest.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96883/new/

https://reviews.llvm.org/D96883

Files:
  llvm/docs/CommandGuide/llvm-symbolizer.rst
  llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h
  llvm/lib/DebugInfo/Symbolize/DIPrinter.cpp
  llvm/test/tools/llvm-symbolizer/output-style-json-data.test
  llvm/test/tools/llvm-symbolizer/output-style-json-frame.test
  llvm/test/tools/llvm-symbolizer/output-style-json.test
  llvm/tools/llvm-symbolizer/Opts.td
  llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96883.329985.patch
Type: text/x-patch
Size: 29080 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210311/dac57a58/attachment.bin>


More information about the llvm-commits mailing list