[PATCH] D98417: [Orc] Fix race condition in DebugObjectManagerPlugin

[Lang Hames via Phabricator via llvm-commits]

lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.

LGTM.

> This might introduce a considerable delay in materialization. I wonder if this points out an interesting design question for the plugin API...

I think you're right, but rather than approach this through the plugin API I think the solution will come from rethinking "finalization" on the memory manager API: If we represented all the various pieces of metadata (eh-frames, objc registration, debug registration, etc.) as sections in the allocation, and allowed additional operations to be attached to the finalization call, then we could do everything in one RPC round trip.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98417/new/

https://reviews.llvm.org/D98417