[PATCH] D96469: [AMDGPU] Use single cache policy operand

Wed Mar 10 11:56:22 PST 2021

rampitec added inline comments.

================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp:1519
+                                           SDValue &CPol) const {
+  if (!CPol.getNode())
+    CPol = CurDAG->getTargetConstant(AMDGPU::CPol::GLC, SDLoc(Addr), MVT::i32);
----------------
rampitec wrote:
> arsenm wrote:
> > Don't need the .getNode. Also we should be removing this from the complex patterns since they're never used (I thought I made progress on this but don't remember what the issue was)
> I could not get a value of a default operand if a ComplexPattern is used.
Actually it seems to be possible to remove at least some of these...

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96469/new/

https://reviews.llvm.org/D96469