[PATCH] D98385: [lld-macho] Fix handling of X86_64_RELOC_SIGNED_{1,2,4}

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 11 07:29:45 PST 2021


thakis accepted this revision.
thakis added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/MachO/InputFiles.cpp:308
         // that it describes the offset from the start of the referent section.
+        // XXX This logic was written around x86_64 behavior -- ARM64 doesn't
+        // have pcrel section relocations. We may want to factor this out into
----------------
nit: llvm uses "FIXME" as the default todo comment, not XXX or TODO


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98385/new/

https://reviews.llvm.org/D98385



More information about the llvm-commits mailing list