[PATCH] D98397: [AMDGPU] Restrict image_msaa_load to MSAA dimension types

[Carl Ritson via Phabricator via llvm-commits]

critson marked an inline comment as done.
critson added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:4156
+  if (!validateMIMGMSAA(Inst)) {
+    Error(IDLoc, "invalid dim; must be MSAA type");
+    return false;
----------------
dp wrote:
> You could improve error position using
> 
> ```
>     getImmLoc(AMDGPUOperand::ImmTyDim, Operands)
> ```
Thanks for pointing this out!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98397/new/

https://reviews.llvm.org/D98397