[PATCH] D83744: [Attributor] Attributor call site specific AAValueConstantRange

[Kuter Dinel via Phabricator via llvm-commits]

kuter added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:1138
+    }
+#endif
+    if (!shouldPropagateCallBaseContext(IRP))
----------------
RKSimon wrote:
> @kuter This is breaking some EXPENSIVE_CHECKS builds such as http://lab.llvm.org:8011/#/builders/16/builds/7624
> 
> AbstractAttribute isn't defined until later in the header - oddly my MSVC build is quite happy (after my fix at rGe74d6269259e28225a494ce98bd1762cdac1fe89)
Thanks , I am aware of this. CMake decided to rebuild everything after I did a git pull.
I am waiting for it to compile right now.

I just assumed that enabling assertions also enabled the expansive checks, I am sorry.
If it still doesn't work after your fix. We can just remove this check for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83744/new/

https://reviews.llvm.org/D83744