[PATCH] D98118: GlobalISel: Partially fix handling of byval arguments

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CallLowering.cpp:632
+
+      if (VA.isMemLoc() && !Flags.isByVal()) {
         // Individual pieces may have been spilled to the stack and others
----------------
paquette wrote:
> Only check `VA.isMemLoc` once?
> 
> ```
> if (VA.isMemLoc()) {
>   if (!Flags.isByVal()) {
>     ...
>     continue;
>   }
>   ...
>   continue;
> }
> ```
Maybe, but it increases the indentation for 2 cases that don't really have much in common


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98118/new/

https://reviews.llvm.org/D98118