[PATCH] D98387: [lld-macho] Check address ranges when applying relocations

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: lld/MachO/Arch/ARM64.cpp:162
+    checkInt(r, value - pc, 28);
     value = encodeBranch26(base, value - pc);
     break;
----------------
(Should the check be in encodeBranch26() instead (etc)? The we won't miss it for other calls, and the 26/28 discrepancy is maybe a bit less magical when the check is closer to the shift.


================
Comment at: lld/MachO/Arch/ARM64.cpp:180
+    checkInt(r, pageDiff, 35);
+    value = encodePage21(base, pageDiff);
     break;
----------------
(same question)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98387/new/

https://reviews.llvm.org/D98387