[PATCH] D98190: [NFC] Use SmallString instead of std::string for the AttrBuilder

[serge via Phabricator via llvm-commits]

serge-sans-paille added a comment.

In D98190#2613701 <https://reviews.llvm.org/D98190#2613701>, @bkramer wrote:

> Do we have some information on how long these attributes typically are? libc++'s std::string has an inline capacity of 22, which is why I've been reluctant to change this so far.

Here is what I know fore sure:

When parsing the SQLite amalgametion and counting the number of instructions, which is a fairly stable metric:

  perf stat ./bin/clang -w -c sqlite3.c -o/dev/null

I get 6,005,593,103 instructions *before* that patch and 5,974,383,558 instructions *after* the patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98190/new/

https://reviews.llvm.org/D98190