[PATCH] D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands

Thu Mar 11 04:46:16 PST 2021

jmorse added a comment.

In D91722#2617949 <https://reviews.llvm.org/D91722#2617949>, @StephenTozer wrote:

> Modified `salvageDebugInfoForDbgValues` to only produce DIArgLists for dbg.values, and not dbg.addr or dbg.declare. This is necessary for the time being, as the current implementation of variadic debug values only works with `DW_OP_stack_value` for reasons previously discussed on the mailing list and in the root patch of this stack. In the next patch to follow, which will make the current `DBG_VALUE_LIST` into the default debug value instruction, the DIExpression representation will be changed to support non-stack_value variadic debug values, and this change can be reverted.

SGTM

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91722/new/

https://reviews.llvm.org/D91722