[PATCH] D98288: [DSE] Translate killing locations through phis.

Evgeniy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 11 01:58:57 PST 2021


ebrevnov added a comment.

In general this patch seems to take exactly the same direction as D90095 <https://reviews.llvm.org/D90095> and is a strict subset of it. We can choose to either re-build functionality step by step or take D90095 <https://reviews.llvm.org/D90095> and split it to several smaller pieces. D90095 <https://reviews.llvm.org/D90095> adds the follwoing functionality:

1. Replaces main 'do-while' loop to 'for' loop in getDomMemoryDef. This is NFC and aimed at simplifying code structure and allows to minimize future changes.
2. Supports phi translation to any predecessor (not only immediate one)
3. Is able to phi translate in presence of geps and casts. In order to support this we have to track offests.

Please let me know which way you prefer to go.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98288/new/

https://reviews.llvm.org/D98288



More information about the llvm-commits mailing list