[PATCH] D98394: [RISCV] Support fixed vector copysign.

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 11 01:15:25 PST 2021


frasercrmck accepted this revision.
frasercrmck added a comment.
This revision is now accepted and ready to land.

LGTM otherwise.



================
Comment at: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-fp.ll:419
+
+define void @copysign_neg_v2f64(<2 x double>* %x, <2 x double>* %y) {
+; CHECK-LABEL: copysign_neg_v2f64:
----------------
It might be worthwhile adding some extra tests to cover the FCOPYSIGN dag combine which reorders fpext/fptrunc and fneg. It looks like it was written such that it "just works" but you never know.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98394/new/

https://reviews.llvm.org/D98394



More information about the llvm-commits mailing list