[PATCH] D98323: [lld-macho] implement options -map

[Roy via Phabricator via llvm-commits]

woshiccm added a comment.

In D98323#2616678 <https://reviews.llvm.org/D98323#2616678>, @thakis wrote:

> Thanks for the patch!
>
> Overall, looks pretty good.
>
> Please clang-format the file (make the comments in the first few lines <= 80 cls first).
>
> Please add a test.
>
> Does ld64 print CommonSymbols, or does this run late enough that they've already been replaced by Defineds? (A good thing to include in the test.)
>
> lld/MachO doesn't use TimeTraceScope anywhere else yet (it should!), so it's a bit weird to have it here. Maybe should add actual time trace support in a patch before this? But I suppose that part is fine as-is as well.

I had Fixed the format. Yes, CommonSymbols have already been replaced by Defineds.
Could we merge this patch first, and then I add test?I am not familiar with writing tests yet, it may take some time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98323/new/

https://reviews.llvm.org/D98323