[PATCH] D93927: [ArgPromotion] Copy !range metadata for loads.

[Chenguang Wang via Phabricator via llvm-commits]

wecing updated this revision to Diff 329845.
wecing added a comment.

Only copy seleted metadata.

Thank you @fhahn for the response. I went through the metadata types mentioned in https://llvm.org/docs/LangRef.html#load-instruction, and those listed in https://llvm.org/docs/LangRef.html#metadata that mentiones could be used on 'load', and hand picked those I think should be safe to copy.

Since I do not have write access to the repo, if this change looks good to you, would you want to commit it on my behalf?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93927/new/

https://reviews.llvm.org/D93927

Files:
  llvm/lib/Transforms/IPO/ArgumentPromotion.cpp
  llvm/test/Transforms/ArgumentPromotion/metadata.ll


Index: llvm/test/Transforms/ArgumentPromotion/metadata.ll
===================================================================
--- /dev/null
+++ llvm/test/Transforms/ArgumentPromotion/metadata.ll
@@ -0,0 +1,44 @@
+; RUN: opt < %s -argpromotion -S | FileCheck %s
+
+define i32 @should_copy_range({ i32, i32 }* %x) {
+; CHECK-LABEL: define i32 @should_copy_range(
+; CHECK:         %x.idx = getelementptr { i32, i32 }, { i32, i32 }* %x, i64 0, i32 0
+; CHECK-NEXT:    %x.idx.val = load i32, i32* %x.idx, align 4, !range !0
+; CHECK-NEXT:    %1 = call i32 @f_load_range(i32 %x.idx.val)
+; CHECK-NEXT:    ret i32 %1
+;
+  %1 = call i32 @f_load_range({ i32, i32 }* %x)
+  ret i32 %1
+}
+
+define internal i32 @f_load_range({ i32, i32 }* %v) {
+; CHECK-LABEL: define internal i32 @f_load_range(
+; CHECK:         ret i32
+;
+  %1 = getelementptr inbounds { i32, i32 }, { i32, i32 }* %v, i64 0, i32 0
+  %2 = load i32, i32* %1, align 4, !range !0
+  ret i32 %2
+}
+
+define i32* @should_copy_nonnull({ i32*, i32* }* %x) {
+; CHECK-LABEL: define i32* @should_copy_nonnull(
+; CHECK:         %x.idx = getelementptr { i32*, i32* }, { i32*, i32* }* %x, i64 0, i32 0
+; CHECK-NEXT:    %x.idx.val = load i32*, i32** %x.idx, align 4, !nonnull !1
+; CHECK-NEXT:    %1 = call i32* @f_load_nonnull(i32* %x.idx.val)
+; CHECK-NEXT:    ret i32* %1
+;
+  %1 = call i32* @f_load_nonnull({ i32*, i32* }* %x)
+  ret i32* %1
+}
+
+define internal i32* @f_load_nonnull({ i32*, i32* }* %v) {
+; CHECK-LABEL: define internal i32* @f_load_nonnull(
+; CHECK:         ret i32*
+;
+  %1 = getelementptr inbounds { i32*, i32* }, { i32*, i32* }* %v, i64 0, i32 0
+  %2 = load i32*, i32** %1, align 4, !nonnull !1
+  ret i32* %2
+}
+
+!0 = !{i32 0, i32 4}
+!1 = !{}
Index: llvm/lib/Transforms/IPO/ArgumentPromotion.cpp
===================================================================
--- llvm/lib/Transforms/IPO/ArgumentPromotion.cpp
+++ llvm/lib/Transforms/IPO/ArgumentPromotion.cpp
@@ -312,6 +312,12 @@
           AAMDNodes AAInfo;
           OrigLoad->getAAMetadata(AAInfo);
           newLoad->setAAMetadata(AAInfo);
+          // And other metadata.
+          newLoad->copyMetadata(
+              *OrigLoad,
+              {LLVMContext::MD_nontemporal, LLVMContext::MD_nonnull,
+               LLVMContext::MD_dereferenceable, LLVMContext::MD_align,
+               LLVMContext::MD_noundef, LLVMContext::MD_range});
 
           Args.push_back(newLoad);
           ArgAttrVec.push_back(AttributeSet());


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93927.329845.patch
Type: text/x-patch
Size: 2477 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210311/925f9a47/attachment.bin>