[PATCH] D98389: [IndirectCallPromotion] Don't strip ".__uniq." suffix when it strips ".llvm." suffix.
Wenlei He via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 10 20:52:13 PST 2021
wenlei added inline comments.
================
Comment at: llvm/lib/ProfileData/InstrProf.cpp:359
if (InLTO) {
- auto pos = PGOFuncName.find('.');
+ auto pos = PGOFuncName.find(".llvm.");
if (pos != std::string::npos) {
----------------
tmsriram wrote:
> Not too familiar with this code, is there a chance you could have a different suffix other than "__uniq" before the .llvm suffix like say "constprop" ? In this case that suffix would be retained by this change which would be different from the original behavior.
`getCanonicalFnName` has other known suffixes, do we need to consider these as well?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98389/new/
https://reviews.llvm.org/D98389
More information about the llvm-commits
mailing list