[PATCH] D98381: [lld-macho] Handle error cases properly for -exported_symbol(s_list)

Greg McGary via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 10 18:32:33 PST 2021


gkm created this revision.
gkm added a reviewer: lld-macho.
Herald added a reviewer: int3.
Herald added a project: lld-macho.
gkm requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This fixes defects in D98223 <https://reviews.llvm.org/D98223> [lld-macho] implement options -(un)exported_symbol(s_list):

- disallow export of hidden symbols
- verify that whitelisted literal names are defined in the symbol table
- reflect export-status overrides in `nlist` attribute of `N_EXT` or `N_PEXT`

Thanks to @thakis for raising these issues


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D98381

Files:
  lld/MachO/Config.h
  lld/MachO/SymbolTable.cpp
  lld/MachO/SymbolTable.h
  lld/MachO/SyntheticSections.cpp
  lld/test/MachO/export-options.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98381.329815.patch
Type: text/x-patch
Size: 7378 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210311/174b4346/attachment.bin>


More information about the llvm-commits mailing list