[PATCH] D98322: [llvm] Fix thinko in getVendorSignature(), where expected values of ECX and EDX were flipped for the AMD case.
Petr Penzin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 10 18:18:53 PST 2021
ppenzin accepted this revision.
ppenzin added a comment.
This revision is now accepted and ready to land.
Looks good in general, with one minor nit (inline).
================
Comment at: llvm/lib/Support/Host.cpp:514-519
// "Genu ineI ntel"
if (EBX == 0x756e6547 && ECX == 0x6c65746e && EDX == 0x49656e69)
return VendorSignatures::GENUINE_INTEL;
// "Auth enti cAMD"
+ if (EBX == 0x68747541 && ECX == 0x444d4163 && EDX == 0x69746e65)
----------------
Minor nit: comments don't match the order of values.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98322/new/
https://reviews.llvm.org/D98322
More information about the llvm-commits
mailing list