[PATCH] D98307: [RISCV] Remap 'generic' CPU to 'generic-rv32' or 'generic-rv64'. Validate 64Bit feature against the triple.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.cpp:58-59
     CPUName = Is64Bit ? "generic-rv64" : "generic-rv32";
   if (TuneCPUName.empty())
     TuneCPUName = CPUName;
   ParseSubtargetFeatures(CPUName, TuneCPUName, FS);
----------------
jrtc27 wrote:
> jrtc27 wrote:
> > Should we be mapping -mtune=generic to generic-rv$XLEN too?
> (For consistency, and although it seems like a stupid thing to do, maybe you want to override a non-generic default back to generic)
i'm not sure what you mean with "maybe you want to override a non-generic default back to generic"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98307/new/

https://reviews.llvm.org/D98307