[PATCH] D97899: [RuntimeDyld] Support more relocations

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 10 17:54:44 PST 2021


MaskRay added a comment.

The R_X86_64_8 range checking is wrong. See D63690 <https://reviews.llvm.org/D63690>.
It also feels wrong to use `assert` because the relocation overflow can happen and ExecutionEngine should not crash in that case.

LLVM only emits R_X86_64_8 for `!absolute_symbol`. I think `R_X86_64_16` is not used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97899/new/

https://reviews.llvm.org/D97899



More information about the llvm-commits mailing list