[PATCH] D98086: [FileCheck] Fix numeric error propagation

[Joel E. Denny via Phabricator via llvm-commits]

jdenny marked an inline comment as done.
jdenny added inline comments.


================
Comment at: llvm/test/FileCheck/match-time-error-propagation/invalid-excluded-pattern.txt:13
+RUN: echo > %t.chk \
+RUN:      'CHECK-NOT: [[#0x8000000000000000+0x8000000000000000]] [[UNDEF-VAR]]'
+RUN: echo > %t.in '10000000000000000'
----------------
thopre wrote:
> jdenny wrote:
> > thopre wrote:
> > > Did you intend to have two undefined variables (UNDEF and VAR)? Why not just UNDEFVAR? I don't think the parser looks anything after the minus sign.
> > Good catch.  I was trying to hyphenate.   I'll go with UNDEFVAR.
> > 
> > (BTW, the parser doesn't complain when UNDEF is defined.  It just ignores `-VAR`.  We should fix that.)
> > 
> Ouch. Could you create a bug and subscribe me?
https://bugs.llvm.org/show_bug.cgi?id=49531


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98086/new/

https://reviews.llvm.org/D98086