[PATCH] D97007: [lld-macho] Define __mh_bundle_header as symbol (similar to ___dso_handle)

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 10 13:32:59 PST 2021


int3 added a comment.

Testing aside, the most recent changes in the diff don't seem to have addressed the concerns in my earlier comment:

> It really should have most of the semantics of a Defined symbol, and having it as a separate case means it's easy to forget to handle it. I've been thinking of having Defined symbols contain a SectionPointerUnion instead of an InputSection field, which should be all that's needed to model these synthetic symbols.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97007/new/

https://reviews.llvm.org/D97007



More information about the llvm-commits mailing list