[PATCH] D98342: [FileCheck] Fix naming of OverflowErrorStr var

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

Other than a comment request, LGTM.



================
Comment at: llvm/lib/FileCheck/FileCheck.cpp:124
   bool ValueIsSigned = Value == Kind::Signed;
-  StringRef OverflowErrorStr = "unable to represent numeric value";
+  StringRef IntegerParseErrorStr = "unable to represent numeric value";
   if (ValueIsSigned) {
----------------
Could you add a comment somewhere in this function explaining the significance for the FileCheck utility vs. the library?  For me, this point has been a source of confusion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98342/new/

https://reviews.llvm.org/D98342