[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 10 12:16:55 PST 2021


amyk added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:16134
     if (Subtarget.hasPrefixInstrs()) {
-      // With prefixed instructions, we can materialize anything that can be
-      // represented with a 32-bit immediate, not just positive zero.
-      APFloat APFloatOfImm = Imm;
-      return convertToNonDenormSingle(APFloatOfImm);
+      // we can materialize all imms via XXSPLTI32dDX and XXSPLTIDP
+      return true;
----------------
Minor nit on comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95458/new/

https://reviews.llvm.org/D95458



More information about the llvm-commits mailing list