[PATCH] D98204: [NFC] Fix "unused parameter" error revealed in the Linux self-build.

Zahira Ammarguellat via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 10 11:41:58 PST 2021


zahiraam marked 5 inline comments as done.
zahiraam added inline comments.


================
Comment at: llvm/include/llvm/ADT/DenseMapInfo.h:273
   static bool isEqualImpl(const Tuple &lhs, const Tuple &rhs, std::false_type) {
+    (void)rhs;
     using EltType = typename std::tuple_element<I, Tuple>::type;
----------------
aaron.ballman wrote:
> This looks suspicious -- `rhs` looks to be used below in the call to `std:get<I>()` and `isEqualImpl<I + 1>()`. Is this needed?
No that's no needed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98204/new/

https://reviews.llvm.org/D98204



More information about the llvm-commits mailing list