[PATCH] D98027: [NFC][AA] Prepare to convert AliasResult to class with PartialAlias offset.

[Daniil Fukalov via Phabricator via llvm-commits]

dfukalov added inline comments.


================
Comment at: llvm/include/llvm/Analysis/AliasAnalysis.h:77
 /// canonical names from the literature are suffixed and unique anyways, and so
 /// they serve as global constants in LLVM for these results.
 ///
----------------
nikic wrote:
> This paragraph should be dropped.
I declined to make the enum scoped since it's going to be unscoped in a planned `AliasResult` class.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp:50-65
+#define ASMay AliasResult::MayAlias
+#define ASNo AliasResult::NoAlias
+  // This array is indexed by address space value enum elements 0 ... to 7
+  static const AliasResult ASAliasRules[8][8] = {
+    /*                    Flat    Global Region Group  Constant Private Const32 Buf Fat Ptr */
+    /* Flat     */        {ASMay, ASMay, ASNo,  ASMay, ASMay,   ASMay,  ASMay,  ASMay},
+    /* Global   */        {ASMay, ASMay, ASNo,  ASNo,  ASMay,   ASNo,   ASMay,  ASMay},
----------------
@rampitec, I moved the table into the function additionally.
Could you please check defines naming?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98027/new/

https://reviews.llvm.org/D98027