[PATCH] D97155: [MSSA] Extending IsGuaranteedLoopInvariant to support an instruction defined in the entry block

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D97155#2606949 <https://reviews.llvm.org/D97155#2606949>, @fvrmatteo wrote:

> Added a unit test to verify that the modification to **IsGuaranteeLoopInvariant** leads to retaining the location information associated to a MemoryAccess (in this case a MemoryPhi) when handling a pointer defined in the entry block.

Thanks for adding the test!

Is it possible to have a `.ll` test instead of the unit test? If we need a unit test, can we at least parse the IR from a string, to make it a bit easier to see what we are working with (e.g. like in https://github.com/llvm/llvm-project/blob/main/llvm/unittests/Analysis/ValueTrackingTest.cpp#L115)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97155/new/

https://reviews.llvm.org/D97155