[PATCH] D97703: [AsmParser][SystemZ][z/OS] Introducing HLASM Comment Syntax

[Scott Linder via Phabricator via llvm-commits]

scott.linder accepted this revision.
scott.linder added a comment.
This revision is now accepted and ready to land.

Thank you for coming up with a way to test the change! It LGTM.

Couple minor nits, but if you are OK with the requested changes feel free to make them and commit without updating the review



================
Comment at: llvm/unittests/MC/SystemZ/SystemZAsmLexerTest.cpp:52
+  // Get the SystemZ Target info.
+  const Target *getTarget(std::string Triple) {
+    std::string Error;
----------------
Can be `static`


================
Comment at: llvm/unittests/MC/SystemZ/SystemZAsmLexerTest.cpp:69
+    TheTarget = getTarget(TripleName);
+    EXPECT_NE(TheTarget, nullptr);
+
----------------
I think these should be `ASSERT_NE`, because the rest of the test relies on this


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97703/new/

https://reviews.llvm.org/D97703