[PATCH] D98263: [LoopInterchange] fix tightlyNested() in LoopInterchange legality

Congzhe Cao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 10 09:06:14 PST 2021


congzhe updated this revision to Diff 329684.
congzhe added a comment.

Updated the patch.

Added the abovementioned test case to "not-interchanged-tightly-nested.ll", and made appropriate updates in the patch to handle this new test cases. The updates are as follows.

As mentioned above, LoopNest::checkLoopsStructure() is a bit too comprehensive and includes scenarios (e.g., the new test case) where loop interchange transformation cannot handle, so I used the previous check from `tightlyNested()` instead, which would fail "tightlyNest" check and would not enter transformation, hence would not crash.

All other regression test cases are ok, no failure observed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98263/new/

https://reviews.llvm.org/D98263

Files:
  llvm/lib/Transforms/Scalar/LoopInterchange.cpp
  llvm/test/Transforms/LoopInterchange/not-interchanged-tightly-nested.ll
  llvm/test/Transforms/LoopInterchange/pr48113.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98263.329684.patch
Type: text/x-patch
Size: 5073 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210310/929be42b/attachment.bin>


More information about the llvm-commits mailing list