[PATCH] D98225: [flang] Sort symbols by creation order

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld added inline comments.


================
Comment at: flang/include/flang/Semantics/symbol.h:703
   blockType *currBlock_{nullptr};
+  static inline std::size_t symbolCount_ = 0;
 
----------------
PeteSteinfeld wrote:
> klausler wrote:
> > tskeith wrote:
> > > This doesn't need to be static.
> > It need not be static today, since there's just one static instance of this class; but there would be a subtle bug in the future if this member were not static and somebody needed another Symbol allocator instance for inlining or whatever.
> Thanks, Tim.  I'll change this.
Good point, Peter.  I'll fix this in a follow-in update.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98225/new/

https://reviews.llvm.org/D98225